Add the font PT Astra Serif as a possible substitution for Times New Roman #20394
Conversation
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9919e5c49c0afa0/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/cac78d3ee45096e/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/9919e5c49c0afa0/output.txt Total script time: 38.95 mins
Image differences available at: http://54.241.84.105:8877/9919e5c49c0afa0/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/cac78d3ee45096e/output.txt Total script time: 78.04 mins
Image differences available at: http://54.193.163.58:8877/cac78d3ee45096e/reftest-analyzer.html#web=eq.log |
|
Looks like all test failures are about a different font grayscale antialias. And many of them don't even use 'Times Roman'. I have no idea about the relation between failure and my change (Just add a new font to 'Times Roman' fallback list.). |
|
The reference test failures are not related to your patch. The reason for the differences is that Firefox Nightly got updated on the bots a few days ago, which ever so slightly changed font rendering for some PDF files. To fix this we just have to regenerate the reference test images with the new version, which is being done over at #20397. Once that's done we can re-run the tests here. In the meantime, could you perhaps add a test case (PDF file) to this PR that serves as a regression test to make sure that the font substitution works, and keeps working, as expected? A simple one-page PDF file with some text in this font (probably without embedding the font) will suffice. You can look at https://github.com/mozilla/pdf.js/pull/20270/files as an example of how to do this: basically it involves adding the PDF file itself, updating Thank you! |
CoelacanthusHex
force-pushed
the
feat/pt-astra-serif
branch
2 times, most recently
from
f57fce4 to
624bb2c
Compare
Ok. I added a new test PDF, which used PT Astra Serif and without embedded it. |
…Roman Metric-compatible font with Times New Roman created by ParaType, based on their serif font PT Serif, released under OFL-1.1 license. https://www.paratype.com/fonts/pt/pt-astra-serif Signed-off-by: Coelacanthus <[email protected]>
CoelacanthusHex
force-pushed
the
feat/pt-astra-serif
branch
from
624bb2c to
dceac03
Compare
4 participants
Metric-compatible font with Times New Roman created by ParaType, based on their serif font PT Serif, released under OFL-1.1 license.
https://www.paratype.com/fonts/pt/pt-astra-serif